Upgrade webpack to 4.35.0 to fix dynamic import issue#7257
Merged
iansu merged 2 commits intofacebook:masterfrom Jun 24, 2019
Merged
Upgrade webpack to 4.35.0 to fix dynamic import issue#7257iansu merged 2 commits intofacebook:masterfrom
iansu merged 2 commits intofacebook:masterfrom
Conversation
iansu
requested review from
Timer,
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
mrmckeb and
petetnt
as code owners
ianschmitz
approved these changes
Jun 21, 2019
Contributor
Author
|
I hope this fixes the issue anyway. If CI passes I'll look into adding a test to verify the fix and make sure it doesn't break again. |
mrmckeb
approved these changes
Jun 24, 2019
Contributor
mrmckeb
left a comment
mrmckeb
left a comment
There was a problem hiding this comment.
I assume you've reviewed the changelog, and this passes the CI, so approved from me!
ianschmitz
approved these changes
Jun 24, 2019
Contributor
|
Whoops. Double approved! 😛 |
Contributor
|
@ianschmitz is excited about this PR! |
iansu
commented
Jun 24, 2019
| this.setFeature(f.default) | ||
| ); | ||
| break; | ||
| case 'dynamic-import': |
Contributor
Author
There was a problem hiding this comment.
How does this even work? Also, the tests themselves use a dynamic import and they didn't break previously.
Contributor
Author
|
🤷♂ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7254