Skip to content

Fix for #6720: HMR not working in Firefox if proxy option present #7444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrmckeb merged 3 commits into from
Aug 7, 2019
+6 −2
Merged

Fix for #6720: HMR not working in Firefox if proxy option present #7444

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2066da9
All get requests for /sockjs-node* excluded from processing by http-p…
mrmckeb Jul 28, 2019
2059bb0
All get requests for /sockjs-node* excluded from processing by http-p…
dmile Jul 28, 2019
6609da4
Merge remote-tracking branch 'origin/fix-hmr-for-firefox' into fix-hm…
dmile Jul 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/react-dev-utils/WebpackDevServerUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,10 +361,14 @@ function prepareProxy(proxy, appPublicFolder) {
process.exit(1);
}

// If proxy is specified, let it handle any request except for files in the public folder.
// If proxy is specified, let it handle any request except for
// files in the public folder and requests to the WebpackDevServer socket endpoint.
// https://github.com/facebook/create-react-app/issues/6720
function mayProxy(pathname) {
const maybePublicPath = path.resolve(appPublicFolder, pathname.slice(1));
return !fs.existsSync(maybePublicPath);
const isPublicFileRequest = fs.existsSync(maybePublicPath);
const isWdsEndpointRequest = pathname.startsWith('/sockjs-node'); // used by webpackHotDevClient
return !(isPublicFileRequest || isWdsEndpointRequest);
}

if (!/^http(s)?:\/\//.test(proxy)) {
Expand Down