Skip to content

fix: make error overlay fontsize larger #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lxfriday
Copy link

@lxfriday lxfriday commented Oct 10, 2019

Fixes #7799.

before
image

after
image

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz self-assigned this Oct 12, 2019
Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better solution is to change this line:

to fontSize: '0.7rem' and revert the changes you have currently.. For those that use the standard font size it will be roughly the same size as today, but will scale with the font size if the user overrides the default such as through their browser settings.

@ianschmitz ianschmitz added this to the 3.2.1 milestone Oct 12, 2019
@ianschmitz ianschmitz changed the title fix: make error overlay fontsize larger #7799 fix: make error overlay fontsize larger Oct 12, 2019
@iansu iansu modified the milestones: 3.2.1, 3.3 Oct 23, 2019
@ianschmitz ianschmitz modified the milestones: 3.3, 3.4 Dec 5, 2019
@iansu iansu modified the milestones: 3.4, 3.5 Feb 14, 2020
@ianschmitz
Copy link
Contributor

There's some significant work happening with the error overlay in general and there hasn't been any activity here in a long time, so i'm going to close. Thanks for the PR!

@ianschmitz ianschmitz closed this May 7, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make font size of error overlay configurable
4 participants