Skip to content

Android: Add support to pass Touch events through native views#28956

Closed
stephenkopylov wants to merge 3 commits into
facebook:mainfrom
ibitcy:master
Closed

Android: Add support to pass Touch events through native views#28956
stephenkopylov wants to merge 3 commits into
facebook:mainfrom
ibitcy:master

Conversation

@stephenkopylov
Copy link
Copy Markdown

@stephenkopylov stephenkopylov commented May 23, 2020

Summary

The main reason explained here:
#28953

Changelog

[Android] [Added] - onTouchEvent-alternative for JSTouchDispatcher ReactViewGroup

Test Plan

Now we can easily do things like this:
out

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @stephenkopylov!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels May 23, 2020
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 23, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 10,747,088 9,937,520

Base commit: 60b7a30

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,780,379 101
android hermes armeabi-v7a 6,442,611 82
android hermes x86 7,165,480 90
android hermes x86_64 7,056,130 66
android jsc arm64-v8a 8,948,158 81
android jsc armeabi-v7a 8,602,789 77
android jsc x86 8,776,379 70
android jsc x86_64 9,352,667 63

Base commit: 60b7a30

@sudomann
Copy link
Copy Markdown

@stephenkopylov I see this PR has been sitting for about a year now 😄

@CezarCobuz
Copy link
Copy Markdown

@stephenkopylov could you please look into conflicts? Maybe this will get it on step closer to being merged

@stephenkopylov
Copy link
Copy Markdown
Author

@CezarCobuz sorry for disappearing - I'll try to get back into issue in closest few weeks!

@ShivamJoker
Copy link
Copy Markdown

Seems like more than a month 😉

@adgang
Copy link
Copy Markdown

adgang commented Sep 22, 2022

Any progress on this? I don't see any alternative to this use case in https://github.com/ibitcy/react-native-hole-view
At least none that is so straightforward.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2023

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label May 6, 2023
@github-actions
Copy link
Copy Markdown

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions Bot closed this May 13, 2023
@YDaskaloff
Copy link
Copy Markdown

What's going on here? Is this going to be merged? It's such a good addition to react-native!

@nvictor-acv
Copy link
Copy Markdown

WE NEED THIS IN RN, COME ON YOU GUYS! WTF?

@ranjandsingh
Copy link
Copy Markdown

Any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.