Remove redundant logic #13502
Merged
Remove redundant logic #13502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashant-andani
approved these changes
Sep 12, 2018
|
Hello, is there anyone could look at this or I miss something? |
|
@NE-SmallTown Sorry it's taken me a while to look at this! Pretty busy over here as we prepare for React Conf. Looks fine to me :) |
acdlite
pushed a commit
to plievone/react
that referenced
this pull request
Oct 5, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the value of
lowestPriorityPendingInteractiveExpirationTime === NoWorkis always same with theexpirationTime > lowestPriorityPendingInteractiveExpirationTime(If not, we need add some tests). So we could remove the former.