Skip to content

Delete TapEventPlugin #13630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Delete TapEventPlugin #13630

merged 1 commit into from
Sep 12, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 12, 2018

We were only using it for our custom FB bundle. I removed last usage in https://fburl.com/diff/szqmivh3 so we can finally delete this.

@sizebot
Copy link

sizebot commented Sep 12, 2018

ReactDOM: size: -0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: a079011...f120e11

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.0% -0.0% 652 KB 651.98 KB 152.81 KB 152.81 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 92.21 KB 92.2 KB 30.02 KB 30.02 KB UMD_PROD
react-dom.development.js -0.0% -0.0% 647.36 KB 647.34 KB 151.42 KB 151.42 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 92.2 KB 92.19 KB 29.67 KB 29.67 KB NODE_PROD
ReactDOM-dev.js -0.6% -0.9% 668.34 KB 664.25 KB 153.5 KB 152.16 KB FB_WWW_DEV
ReactDOM-prod.js -1.1% -1.6% 287.17 KB 284.1 KB 53.3 KB 52.48 KB FB_WWW_PROD
react-dom.profiling.min.js -0.0% -0.0% 95.24 KB 95.23 KB 30.35 KB 30.35 KB NODE_PROFILING
ReactDOM-profiling.js -1.0% -1.5% 294.05 KB 290.97 KB 54.8 KB 53.96 KB FB_WWW_PROFILING

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@gaearon gaearon merged commit 2282400 into facebook:master Sep 12, 2018
@gaearon gaearon deleted the tappp branch September 12, 2018 18:53
Simek pushed a commit to Simek/react that referenced this pull request Oct 25, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants