Merged
Conversation
Contributor
|
Will this work in Windows if the user strictly has Git installed with nothing added to PATH? |
Contributor
Author
|
I believe it comes with git bash. Depending on the installation of git, if those unix tools get added to the PATH then it should work. |
|
I have GIT in my PATH but returns: |
Contributor
Author
Contributor
|
We don't mind much about the local scripts, but I believe there is a pull request transitioning these to use Node so that they are cross platform. |
Contributor
|
I trust you that this still works. Thanks! |
Contributor
Author
|
Tested both on OSX and Windows. It works as describe in the screenshot above and now it handles filenames with spaces. |
placenamehere
pushed a commit
to automatastudios/create-react-app
that referenced
this pull request
Nov 30, 2017
* improve eject message * cross os implementation
Merged
ghost
mentioned this pull request
This was referenced Feb 2, 2018
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
* improve eject message * cross os implementation
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Aug 14, 2018
* improve eject message * cross os implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2797, override #2838.