Skip to content

Merge in games-on-k8s/docker-factorio gen_config #299

@deefdragon

Description

@deefdragon

games-on-k8s/docker-factorio has been effectively abandoned, but has gen_config.py, which is very powerful for the creation of the server-settings.json file. Addition of gen_config would allow for one line server launches (as opposed to starting, stoping, editing the config, and restarting), much easier kubernetes integration, and much easier public hosting of games.

License is also MIT.

I would be willing to do the merge, testing, and PR if the addition of gen_config.py is acceptable.

Activity

SuperSandro2000

SuperSandro2000 commented on Dec 24, 2019

@SuperSandro2000
Member

I don't really want to add python just for generating the config.

deefdragon

deefdragon commented on Dec 24, 2019

@deefdragon
Author

Just checked, and you do have busybox sed in the container. I would be willing to write a bash script that took a template and replaced all the values with either defaults, or the environment parameters. Only additions then would be the template and new script.

It would not take much to actually expand the script to any other configs that the user may want to edit.

SuperSandro2000

SuperSandro2000 commented on Dec 24, 2019

@SuperSandro2000
Member

We can also add the standalone sed cause compared to full blown python it is tiny.
I would merge it if it is error proof (eg missing variables) and maintainable.

deefdragon

deefdragon commented on Jan 27, 2020

@deefdragon
Author

Moved to PR #304

jonfairbanks

jonfairbanks commented on Jan 28, 2020

@jonfairbanks

This would be an awesome addition, thanks for taking this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @jonfairbanks@deefdragon@SuperSandro2000

    Issue actions

      Merge in games-on-k8s/docker-factorio gen_config · Issue #299 · factoriotools/factorio-docker