-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feature: Improved commands for Pin/Unpin #11729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Improved commands for Pin/Unpin #11729
Conversation
Can you fill out this section? It helps me know what to test. |
There is no visible change for the user, just more complete code (for example if we add a button, its state will always be correct, it was not the case before). There are also hard-to-predict exceptions that have been fixed. |
Is there a good way to test the state? |
Edit bookmarks in FileExplorer, and see if this is reflected in the context menu. The state is no longer checked when the menu is opened, it is an updated value when it detects a modification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fixed: Selection isn't cleared when switching between panes (files-community#11745) * New Crowdin updates (files-community#11747) * Feature: Improved commands for Pin/Unpin (files-community#11729) * Feature: RichCommands Cut/Copy (files-community#11752) * Fix PageContext (files-community#11751) * Feature: Auto update feature of FilesLauncher (files-community#11750) * Fix: Fixed issue with resolving paths containing dots --------- Co-authored-by: Filippo Ferrario <[email protected]> Co-authored-by: Yair <[email protected]> Co-authored-by: cinqmilleans <[email protected]> Co-authored-by: Filippo Ferrario <[email protected]>
Resolved / Related Issues
Improves commands Pin/UnPin (text, perf, IsExecutable criteria more complete, IsExecutable notify even from FileExplorer).
Fix a modified list exception during its enumeration (when IsExecutable is updated while the favorites list is modified).
Closes #issue...
Validation
How did you test these changes?