Skip to content

Feature: Improved commands for Pin/Unpin #11729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

cinqmilleans
Copy link
Contributor

Resolved / Related Issues
Improves commands Pin/UnPin (text, perf, IsExecutable criteria more complete, IsExecutable notify even from FileExplorer).
Fix a modified list exception during its enumeration (when IsExecutable is updated while the favorites list is modified).

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@yaira2 yaira2 changed the title Improves commands Pin/Unpin Feature: Improved commands for Pin/Unpin Mar 15, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 15, 2023

Are there any other steps that were used to validate these changes?

Can you fill out this section? It helps me know what to test.

@cinqmilleans
Copy link
Contributor Author

There is no visible change for the user, just more complete code (for example if we add a button, its state will always be correct, it was not the case before). There are also hard-to-predict exceptions that have been fixed.

@yaira2
Copy link
Member

yaira2 commented Mar 15, 2023

Is there a good way to test the state?

@cinqmilleans
Copy link
Contributor Author

Edit bookmarks in FileExplorer, and see if this is reflected in the context menu. The state is no longer checked when the menu is opened, it is an updated value when it detects a modification.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 17, 2023
@yaira2 yaira2 merged commit dc40fe1 into files-community:main Mar 17, 2023
hishitetsu added a commit to hishitetsu/Files that referenced this pull request Mar 18, 2023
* Fixed: Selection isn't cleared when switching between panes (files-community#11745)

* New Crowdin updates (files-community#11747)

* Feature: Improved commands for Pin/Unpin (files-community#11729)

* Feature: RichCommands Cut/Copy (files-community#11752)

* Fix PageContext (files-community#11751)

* Feature: Auto update feature of FilesLauncher (files-community#11750)

* Fix: Fixed issue with resolving paths containing dots

---------

Co-authored-by: Filippo Ferrario <[email protected]>
Co-authored-by: Yair <[email protected]>
Co-authored-by: cinqmilleans <[email protected]>
Co-authored-by: Filippo Ferrario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants