Skip to content

refactor: improve partitioning code #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

cabljac
Copy link
Contributor

@cabljac cabljac commented Jun 12, 2025

a fresh attempt at refactoring partitioning so it is easier to reason about.

@cabljac cabljac force-pushed the @invertase/fix-partitioning-2 branch from b2060ac to c2e01b4 Compare June 12, 2025 14:55
}
import type { Config } from "./types";
import { PartitioningConfig } from "./partitioning/config";
export type { Config } from "./types";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to decide what to name this type we're exporting

@@ -5,7 +5,7 @@
"url": "github.com/firebase/extensions.git",
"directory": "firestore-bigquery-export/firestore-bigquery-change-tracker"
},
"version": "1.1.38",
"version": "2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made it a breaking change as API for package changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant