Skip to content

Conversation

@tauksun
Copy link
Contributor

@tauksun tauksun commented Oct 25, 2024

Request timeout value correction while sending messaging requests in a batch

@google-cla
Copy link

google-cla bot commented Oct 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lahirumaramba
Copy link
Member

Hey @tauksun Thank you for your contribution. This change is related to #1999
Instead of changing the timeout back to 10 seconds we should rename the constant to FIFTEEN_SECONDS_IN_MILLIS

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lahirumaramba lahirumaramba changed the title request timeout value correction Request timeout value correction Oct 30, 2024
@lahirumaramba lahirumaramba changed the title Request timeout value correction Request timeout const name correction Oct 30, 2024
@lahirumaramba lahirumaramba merged commit 8bb5691 into firebase:master Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

2 participants