Skip to content

[FR] Type hint the source code #569

@takos22

Description

@takos22

Is your feature request related to a problem? Please describe.
When developing with this library, I constantly have to type hint variables returned by the functions, so my autocompleter suggests the right properties and for cleaner code.

Describe the solution you'd like
It would be great if you could type hint the library or at least the public API in order to help type checkers, autocompleters and collaboration.

Describe alternatives you've considered
None

Additional context
None

Activity

google-oss-bot

google-oss-bot commented on Sep 1, 2021

@google-oss-bot

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

self-assigned this
on Sep 1, 2021
lahirumaramba

lahirumaramba commented on Sep 1, 2021

@lahirumaramba
Member

Hi @takos22, Thank you for the feature request!
We agree that this will be a great addition to improve the SDK. While I cannot promise you a timeline at the moment, we will use this github issue to track the progress in the future.

In the meantime, you can also help us speed things up by providing PRs! :)

Mowinski

Mowinski commented on Jun 14, 2023

@Mowinski

Do you have any progress on it? I still get infrastructure\push_notifications.py:7: error: Skipping analyzing "firebase_admi n": module is installed, but missing library stubs or py.typed marker error on mypy :(

heckad

heckad commented on Aug 17, 2023

@heckad

@lahirumaramba, maybe you can add py.typed file to the library? This will remove the message from mypy. And then add types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @lahirumaramba@Mowinski@google-oss-bot@heckad@takos22

      Issue actions

        [FR] Type hint the source code · Issue #569 · firebase/firebase-admin-python