-
Notifications
You must be signed in to change notification settings - Fork 343
Open
Description
Is your feature request related to a problem? Please describe.
When developing with this library, I constantly have to type hint variables returned by the functions, so my autocompleter suggests the right properties and for cleaner code.
Describe the solution you'd like
It would be great if you could type hint the library or at least the public API in order to help type checkers, autocompleters and collaboration.
Describe alternatives you've considered
None
Additional context
None
arslee07, canadianveggie, joshtemple, antony-amdl, mgraczyk and 13 more
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
google-oss-bot commentedon Sep 1, 2021
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
lahirumaramba commentedon Sep 1, 2021
Hi @takos22, Thank you for the feature request!
We agree that this will be a great addition to improve the SDK. While I cannot promise you a timeline at the moment, we will use this github issue to track the progress in the future.
In the meantime, you can also help us speed things up by providing PRs! :)
Mowinski commentedon Jun 14, 2023
Do you have any progress on it? I still get
infrastructure\push_notifications.py:7: error: Skipping analyzing "firebase_admi n": module is installed, but missing library stubs or py.typed marker
error on mypy :(heckad commentedon Aug 17, 2023
@lahirumaramba, maybe you can add
py.typed
file to the library? This will remove the message from mypy. And then add types.