Skip to content

build(deps): bump app.cash.turbine:turbine from 1.2.0 to 1.2.1 #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 12, 2025

Bumps app.cash.turbine:turbine from 1.2.0 to 1.2.1.

Release notes

Sourced from app.cash.turbine:turbine's releases.

1.2.1

Changed

Fixed

  • Calling testIn with a CoroutineScope that does not contain a Job no longer throws IllegalStateException.
Changelog

Sourced from app.cash.turbine:turbine's changelog.

1.2.1 - 2025-06-11

Changed

Fixed

  • Calling testIn with a CoroutineScope that does not contain a Job no longer throws IllegalStateException.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [app.cash.turbine:turbine](https://github.com/cashapp/turbine) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/cashapp/turbine/releases)
- [Changelog](https://github.com/cashapp/turbine/blob/trunk/CHANGELOG.md)
- [Commits](cashapp/turbine@1.2.0...1.2.1)

---
updated-dependencies:
- dependency-name: app.cash.turbine:turbine
  dependency-version: 1.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 12, 2025
Copy link
Contributor

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.0

Copy link
Contributor

github-actions bot commented Jun 12, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Jun 12, 2025

Test Results

   992 files  + 79     992 suites  +79   34m 43s ⏱️ + 11m 52s
 5 426 tests +195   5 405 ✅ +197  21 💤  - 1  0 ❌  - 1 
10 915 runs  +750  10 873 ✅ +753  42 💤  - 2  0 ❌  - 1 

Results for commit 9ef0bf0. ± Comparison against base commit 6a85149.

This pull request removes 559 and adds 754 tests. Note that renamed tests count towards both.
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…

♻️ This comment has been updated with latest results.

@rlazo rlazo requested a review from dconeybe June 23, 2025 17:50
@dconeybe
Copy link
Contributor

dconeybe commented Jun 23, 2025

I've started a run of the "Data Connect Integration Tests" workflow to ensure that the Data Connect integration tests still work with this upgraded version of app.cash.turbine:turbine. I'll open a follow-up PR to ensure that those tests get run for future changes to gradle/libs.versions.toml.

https://github.com/firebase/firebase-android-sdk/actions/runs/15832146210

Update: The build failed with "incompatible kotlin version" errors. I've merged the PR with main, hoping that will fix this problem, since this PR hasn't merged main in 2 weeks.

….2.1
@dconeybe
Copy link
Contributor

I've merged in main and re-triggered the Data Connect integration tests:

https://github.com/firebase/firebase-android-sdk/actions/runs/15832769098

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2025

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.78% (6a85149) to 45.78% (74e0b2b) by -0.00%.

    FilenameBase (6a85149)Merge (74e0b2b)Diff
    DeleteMutation.java95.24%90.48%-4.76%
  • firebase-messaging

    Overall coverage changed from 84.13% (6a85149) to 84.02% (74e0b2b) by -0.11%.

    FilenameBase (6a85149)Merge (74e0b2b)Diff
    Metadata.java41.27%36.51%-4.76%
  • firebase-storage

    Overall coverage changed from 83.92% (6a85149) to 84.33% (74e0b2b) by +0.42%.

    FilenameBase (6a85149)Merge (74e0b2b)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    StreamDownloadTask.java88.41%88.89%+0.48%
    UploadTask.java81.52%83.17%+1.65%
  • firebase-database

    FilenameBase (6a85149)Merge (74e0b2b)Diff
    ViewProcessor.java92.10%91.79%-0.30%
    WriteTree.java76.67%77.22%+0.56%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XYtPtUEjKs.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2025

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (74e0b2b) and the base commit (6a85149) are not available.

No macrobenchmark data found for the base commit (6a85149). Analysis for the CI merge commit (74e0b2b) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/H8Xpuu5LjG/index.html

….2.1
@dconeybe
Copy link
Contributor

This upgrade causes massive build errors like this:

e: Incompatible classes were found in dependencies. Remove them from the classpath or use '-Xskip-metadata-version-check' to suppress errors
> Task :firebase-dataconnect:androidTestutil:compileDebugKotlin
e: file:///home/runner/.gradle/caches/modules-2/files-2.1/app.cash.turbine/turbine-jvm/1.2.1/80767e0dc7df24e2ef980ae47a565d77[262](https://github.com/firebase/firebase-android-sdk/actions/runs/15833837483/job/44632779188?pr=7028#step:7:263)90fa3/Turbine-jvm.jar!/META-INF/Turbine.kotlin_moduleModule was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.1.0, expected version is 1.8.0.

The problematic PR in this upgraded version of "turbine" appears to be cashapp/turbine#400, which upgrades the Kotlin compiler version from 2.1.21 to 2.2.0. Since the firebase-android-sdk project used Android Gradle Plugin v8.3.2 we will probably need to wait for AGP to upgrade to 8.10 or newer (according to https://developer.android.com/build/kotlin-support) before merging this PR.

@dconeybe dconeybe self-assigned this Jun 23, 2025
@rlazo
Copy link
Collaborator

rlazo commented Jun 26, 2025

This upgrade causes massive build errors like this:

e: Incompatible classes were found in dependencies. Remove them from the classpath or use '-Xskip-metadata-version-check' to suppress errors
> Task :firebase-dataconnect:androidTestutil:compileDebugKotlin
e: file:///home/runner/.gradle/caches/modules-2/files-2.1/app.cash.turbine/turbine-jvm/1.2.1/80767e0dc7df24e2ef980ae47a565d77[262](https://github.com/firebase/firebase-android-sdk/actions/runs/15833837483/job/44632779188?pr=7028#step:7:263)90fa3/Turbine-jvm.jar!/META-INF/Turbine.kotlin_moduleModule was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.1.0, expected version is 1.8.0.

The problematic PR in this upgraded version of "turbine" appears to be cashapp/turbine#400, which upgrades the Kotlin compiler version from 2.1.21 to 2.2.0. Since the firebase-android-sdk project used Android Gradle Plugin v8.3.2 we will probably need to wait for AGP to upgrade to 8.10 or newer (according to https://developer.android.com/build/kotlin-support) before merging this PR.

I'd definitely wouldn't expect that a patch version bump changes the dependency of something so critical as Kotlin. I think the safest would be close this PR for now. wdyt?

@dconeybe
Copy link
Contributor

I'd definitely wouldn't expect that a patch version bump changes the dependency of something so critical as Kotlin. I think the safest would be close this PR for now. wdyt?

SGTM. It's just a testing dependency anyways and doesn't affect customers at all. I'm closing it.

@dconeybe dconeybe closed this Jun 26, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 26, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/app.cash.turbine-turbine-1.2.1 branch June 26, 2025 03:05
rlazo pushed a commit that referenced this pull request Jul 8, 2025
I'm re-attempting this upgrade that previously failed in
#7028 now that
kotlin has been upgraded to 2.x in
#7117
@firebase firebase locked and limited conversation to collaborators Jul 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants