Skip to content

Conversation

zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Oct 8, 2025

Changes

Remove "ibpb_exit_to_user" from the host-only feature list if ubuntu.

Reason

Our test ubuntu host kernel hasn't backported the patch for VMScape [1].
Remove "ibpb_exit_to_user" from the host-minus-guest feature list only
on Intel Cascade Lake that is the one where we run tests for Ubuntu.

[1] https://github.com/torvalds/linux/commit/2f8f173413f1cbf52660d04df92d0069c4306d25

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [ ] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [ ] I have mentioned all user-facing changes in CHANGELOG.md.
  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [ ] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Our test ubuntu host kernel hasn't backported the patch for VMScape [1].
Remove "ibpb_exit_to_user" from the host-minus-guest feature list only
on Intel Cascade Lake that is the one where we run tests for Ubuntu.

[1]: torvalds/linux@2f8f173
Signed-off-by: Takahiro Itazuri <[email protected]>
Now Ubuntu 24.04 AMI uses kernel v6.14.

Signed-off-by: Takahiro Itazuri <[email protected]>
@zulinx86 zulinx86 force-pushed the ibpb_exit_to_user_on_ubuntu branch from 1c6127f to 837abb2 Compare October 8, 2025 10:00
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.79%. Comparing base (99365ff) to head (837abb2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5473   +/-   ##
=======================================
  Coverage   82.79%   82.79%           
=======================================
  Files         263      263           
  Lines       27223    27223           
=======================================
  Hits        22538    22538           
  Misses       4685     4685           
Flag Coverage Δ
5.10-m5n.metal 82.97% <ø> (-0.01%) ⬇️
5.10-m6a.metal 82.22% <ø> (ø)
5.10-m6g.metal 79.57% <ø> (-0.01%) ⬇️
5.10-m6i.metal 82.97% <ø> (ø)
5.10-m7a.metal-48xl 82.21% <ø> (ø)
5.10-m7g.metal 79.57% <ø> (-0.01%) ⬇️
5.10-m7i.metal-24xl 82.94% <ø> (-0.01%) ⬇️
5.10-m7i.metal-48xl 82.94% <ø> (-0.02%) ⬇️
5.10-m8g.metal-24xl 79.57% <ø> (-0.01%) ⬇️
5.10-m8g.metal-48xl 79.57% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.00% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.25% <ø> (ø)
6.1-m6g.metal 79.56% <ø> (-0.01%) ⬇️
6.1-m6i.metal 82.99% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.24% <ø> (ø)
6.1-m7g.metal 79.57% <ø> (-0.01%) ⬇️
6.1-m7i.metal-24xl 83.01% <ø> (-0.01%) ⬇️
6.1-m7i.metal-48xl 83.01% <ø> (-0.02%) ⬇️
6.1-m8g.metal-24xl 79.56% <ø> (-0.01%) ⬇️
6.1-m8g.metal-48xl 79.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants