Fix flashinfer.comm module missing

[BBuf]

📌 Description

after fix:

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

• I have installed pre-commit by running pip install pre-commit (or used your preferred method).
• I have installed the hooks with pre-commit install.
• I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

• Tests have been added or updated as needed.
• All tests are passing (unittest, etc.).

Reviewer Notes

[gemini-code-assist]

Summary of Changes

Hello @BBuf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical packaging oversight by ensuring that the flashinfer.comm module is properly included in the project's build configuration. This fix prevents potential 'module not found' errors for users and ensures the complete functionality of the FlashInfer library.

Highlights

• Build Configuration Fix: The flashinfer.comm module has been added to the packages list within pyproject.toml. This ensures that the module is correctly included when the project is built and distributed, resolving an issue where it might have been missing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds the flashinfer.comm package to the pyproject.toml to ensure it's included in the distribution. This will fix ImportError issues for this module.

The PR description is currently empty. It would be helpful to add a brief explanation of the change, for example: "This PR fixes a packaging issue where the flashinfer.comm module was not included in the distribution, causing an ImportError."

While reviewing the code being added in the flashinfer.comm package, I found a few issues. Since these files are not part of the diff, I'm listing them here. It's recommended to address these in a follow-up pull request:

Critical Issue in flashinfer/comm/cuda_ipc.py:

• In the create_shared_buffer function, there appears to be a copy-paste error. The lines handles = [None] * world_size and dist.all_gather_object(handles, handle, group=group) are duplicated (lines 212-213 and 214-215). This makes the first all_gather_object call redundant as its result is immediately discarded.

Medium Severity Issues:

• Duplicated docstring in flashinfer/comm/cuda_ipc.py: The docstring for the create_shared_buffer function is duplicated (lines 198-201 and 202-205).
• Import style in flashinfer/comm/__init__.py: The imports could be cleaned up for better readability. For instance, redundant aliases like ... as AllReduceFusionOp can be removed, and multiple imports from the same module can be consolidated into a single statement.

Addressing these points will improve the overall quality and correctness of the new communication module.