Skip to content

[FL-3008], [FL-2734], [FL-2766], [FL-2898] NFC bug fixes #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skotopes merged 7 commits into from
Dec 7, 2022
Merged

[FL-3008], [FL-2734], [FL-2766], [FL-2898] NFC bug fixes #2098

skotopes merged 7 commits into from
Dec 7, 2022

Conversation

@gornekich
Copy link
Member

@gornekich gornekich commented Dec 6, 2022 •
edited by skotopes
Loading

What's new

Verification

  • NFC cache folder is not displayed in NFC application
  • ATQA is saved in most significant byte first order
  • Read MFC card with known key A and configured access bytes that not allow to read data blocks. Save card. Verify that after next reading with cache keys data blocks are not read.
  • NFC emulation works after reading DESFire or bank cards

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich gornekich marked this pull request as draft December 6, 2022 11:24
@github-actions
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

Compiled firmware for commit 555262a5:

@github-actions
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

PVS-Studio report for commit 555262a5:

@gornekich gornekich mentioned this pull request Dec 6, 2022
Closed
@gornekich gornekich changed the title [FL-3008], [FL-2734], [FL-2898] NFC bug fixes [FL-3008], [FL-2734], [FL-2766], [FL-2898] NFC bug fixes Dec 6, 2022
@gornekich gornekich marked this pull request as ready for review December 6, 2022 17:49
@skotopes skotopes merged commit 9a21dae into dev Dec 7, 2022
@skotopes skotopes deleted the gornek/nfc_bug_fixes branch December 7, 2022 10:52
This was referenced Dec 8, 2022
Closed
Closed
Dig03 pushed a commit to Dig03/flipperzero-firmware that referenced this pull request Dec 31, 2022
@gornekich @skotopes @Dig03
[FL-3008], [FL-2734], [FL-2766], [FL-2898] NFC bug fixes (flipperdevi…
b30ecc8 
…ces#2098)

* nfc: rework mf classic update
* nfc: rename cache folder to .cache
* nfc: fix ATQA order bytes in nfc files
* file browser: add hide dot files option
* nfc: fix iso-14443-4 uid cards emulation
* nfc: fix unit tests

Co-authored-by: あく <[email protected]>
@gornekich gornekich mentioned this pull request Jan 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gornekich @skotopes