Skip to content

Conversation

@xMasterX
Copy link
Contributor

@xMasterX xMasterX commented Jan 6, 2023

This is a working and actual version of previous PR #1525
Originally made by @dummy-decoy and fixed by me

What's new

Verification

  • For this example your pc should be configured to use dvorak layout (or any other one non QWERTY)
  • Open demo script in badusb app, click left button to open config menu, select Keyboard layout
  • Select your layout, for example dvorak
  • Run script - verify that it works correct
  • Select regular ANSI QWERTY layout en-US for example while your PC has dvorak layout
  • Try again, see that script works same as on firmware without these change

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes self-assigned this Jan 6, 2023
@skotopes skotopes added USB BadUSB + physical USB interface New Feature Contains an IMPLEMENTATION of a new feature labels Jan 6, 2023
@skotopes
Copy link
Contributor

skotopes commented Jan 6, 2023

@nminaylov can you take a look?

@skotopes skotopes assigned nminaylov and unassigned skotopes Jan 6, 2023
@skotopes
Copy link
Contributor

skotopes commented Feb 8, 2023

@xMasterX is it ok if @nminaylov will make couple changes in this code?

Also un-draft when ready.

@skotopes skotopes marked this pull request as draft February 8, 2023 07:28
@xMasterX
Copy link
Contributor Author

xMasterX commented Feb 8, 2023

@xMasterX is it ok if @nminaylov will make couple changes in this code?

Also un-draft when ready.

Yes, sure, but I got no answer about hiding our “assets” folder named layouts. It will appear as empty folder in any case except case where we open it in file browser in “archive” app

@xMasterX xMasterX marked this pull request as ready for review February 8, 2023 13:05
@xMasterX
Copy link
Contributor Author

xMasterX commented Feb 8, 2023

@nminaylov
I did all requested changes, but please verify that I made it correctly, also you can do any changes to this PR if you need, I finished my part :)

@skotopes skotopes requested a review from nminaylov February 8, 2023 13:23
@skotopes
Copy link
Contributor

skotopes commented Feb 8, 2023

I'm going to approve and merge this PR. But it does require refactoring.

@skotopes skotopes merged commit b1f5812 into flipperdevices:dev Feb 8, 2023
rwl4 pushed a commit to rwl4/flipperzero-firmware that referenced this pull request Apr 29, 2023
* BadUSB: Keyboard Layouts
* Apply requested changes pt1
* Add layout file check when we loading config

Co-authored-by: Nikolay Minaylov <[email protected]>
Co-authored-by: あく <[email protected]>
nvx pushed a commit to nvx/flipperzero-firmware that referenced this pull request Apr 30, 2023
* BadUSB: Keyboard Layouts
* Apply requested changes pt1
* Add layout file check when we loading config

Co-authored-by: Nikolay Minaylov <[email protected]>
Co-authored-by: あく <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Feature Contains an IMPLEMENTATION of a new feature USB BadUSB + physical USB interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants