Skip to content

Conversation

@zinongli
Copy link
Contributor

@zinongli zinongli commented Jan 31, 2025

What's new

Verification

  1. Read a cute pet and ask them to verify if that indeed is where they come from.
  2. Give them a treat if they said yes.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger
Copy link
Member

hedger commented Feb 3, 2025

This is quite expensive in terms of flash memory consumption. Maybe you could store that data in SD card assets and load on demand?

@hedger hedger added New Feature Contains an IMPLEMENTATION of a new feature RFID 125kHz 125, 134 kHz RFID labels Feb 3, 2025
@zinongli
Copy link
Contributor Author

zinongli commented Feb 3, 2025

Sure. I'll get back to this.

@zinongli zinongli marked this pull request as draft February 3, 2025 18:37
@zinongli
Copy link
Contributor Author

zinongli commented Feb 3, 2025

While looking for ways to assign assets to main apps, I stumbled upon NFC's resource/assets. This country code file seems identical to the look up table we are trying to use here. Is there a way to assign an asset on SD card that can be used by both apps?

I'm fine with mimicing the NFC's process into LFRFID. Just thought maybe I don't have to build the wheel twice.

@zinongli
Copy link
Contributor Author

zinongli commented Feb 3, 2025

Alright. Now it offloads the country list to a .lfrfid resource file. Actually, since it's loading from EXT_PATH, a more unified way to implement this and EMV's country code search would be a single file in a folder in the firmware's ext/asset/ . But since EMV is deprecated for now, it's yor call where to put it. At least this PR works.

@zinongli zinongli marked this pull request as ready for review February 3, 2025 22:30
@skotopes skotopes marked this pull request as draft February 20, 2025 00:56
@skotopes
Copy link
Contributor

Un-draft when ready

@zinongli
Copy link
Contributor Author

I agree. I was overcomplicating things. This version should be much more straighforward. And all using FuriString*, freed within functions.

@zinongli zinongli marked this pull request as ready for review February 20, 2025 01:48
@hedger hedger self-assigned this Apr 5, 2025
@hedger hedger marked this pull request as draft April 6, 2025 22:22
@zinongli zinongli marked this pull request as ready for review July 29, 2025 22:46
@hedger hedger merged commit 8c0c7f1 into flipperdevices:dev Sep 25, 2025
11 checks passed
@zinongli zinongli deleted the iso3166 branch September 26, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Feature Contains an IMPLEMENTATION of a new feature RFID 125kHz 125, 134 kHz RFID

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ISO 3166 to ISO 11784 and ISO 11785 animal reading in the 125 kHz RFID app

3 participants