-
Notifications
You must be signed in to change notification settings - Fork 3.2k
NFC: Type 4 Support (NTAG4xx/DESFire) + Many Improvements #4242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Wow, thank you. Will review and merge soon. |
|
worth to note: this changes behavior of IMO this is better behavior, as one would expect the protocol layer to handle this header, and only receive application data inside the message, and vice versa that when sending data the protocol layer would prefix with the appropriate header; this is same behavior as the iso14443-3a listener, which handles CRC suffix both on rx and tx. @bettse 's app "Seos compatible" for example was affected, as it used the unfinished iso14443-4a listener and handled PCB inside his app. i have made a PR to adapt to this and allow firmware to handle PCB both on listener rx and tx. if other apps are doing iso14443-4a emulation (listener), they probably will need to be adapted aswell. |
What's new
I developed this as my final year project for university, as I have now got my results I'm here to upstream it (I was advised not to deal with uni bureaucracy weirdness so I waited until the course was over)
Verification
Checklist (For Reviewer)