Skip to content

Conversation

@zinongli
Copy link
Contributor

@zinongli zinongli commented Oct 1, 2025

What's new

  • The poller event should only be "Incomplete" if the tag is Lite. If it's Standard then incomplete reading is always expected, since we don't know how large the tag is anyways. So the poller event type enum should be only assigned if it's a Lite tag.

Sorry I missed this in the previous PR. This only came up when I was updating other apps after the PR. If a poller callback is designed for parsing Standard tag's data, it should wait for the poller event type to be FelicaPollerEventTypeReady, instead of an ambiguous FelicaPollerEventTypeIncomplete.

Verification

  • There wasn't a bug per se. But a more accurate logic for assigning event types would reduce confusion in the future.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger
Copy link
Member

hedger commented Nov 6, 2025

Thanks!

@hedger hedger merged commit a42e30f into flipperdevices:dev Nov 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants