fix: device undefined bug and unexpected combined comment bug on PRs #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/foo-software/lighthouse-check-action/AvdAnCTEkvgHnQNuRftPZJWC8f7V |
adamhenson
commented
Apr 7, 2021
adamhenson
changed the title
adamhenson
changed the title
adamhenson
commented
Apr 8, 2021
Collaborator
Author
adamhenson
left a comment
adamhenson
left a comment
There was a problem hiding this comment.
| Device | Report | URL |
|---|---|---|
| mobile | report | https://www.foo.software |
| Device | Report | URL |
|---|---|---|
| desktop | report | https://www.foo.software |
Not what you expected? Are your scores flaky? Run Lighthouse on Foo
adamhenson
commented
Apr 8, 2021
Collaborator
Author
adamhenson
left a comment
adamhenson
left a comment
There was a problem hiding this comment.
| Device | Report | URL |
|---|---|---|
| desktop | report | https://www.foo.software |
| Device | Report | URL |
|---|---|---|
| mobile | report | https://www.foo.software |
| Device | Report | URL |
|---|---|---|
| desktop | report | https://www.foo.software/tag/articles/ |
| Device | Report | URL |
|---|---|---|
| mobile | report | https://www.foo.software/tag/articles/ |
Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bugs reported in the following issues.
Note:
lighthouse-check-actionis essentially a wrapper around@foo-software/lighthouse-checkand these issues were fixed in foo-software/lighthouse-check#47