fix: ensure the Chrome process terminates on error #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have a theory that this will fix the issue raised in #1. Although it's just a theory, this change is an improvement regardless. The expected outcome described in the issue is that a consumer such as a GitHub Action will stop execution on error. An error from this module should bubble up and kill the process. I'm not certain about the inner workings of GitHub actions and what causes them to terminate, but perhaps in this case the actual outcome is that the Chrome process opened by Chrome Launcher from this module is never closed, because the module throws an exception before executing
chrome.kill(). And perhaps because the Chrome process is left open, the GitHub Action never terminates.