fix: patch solang-parser

[DaniPopes]

Hotpatch to foundry-solang-parser maintained at https://github.com/danipopes/solang (branch new-features) (diff) for the following fixes:

• fixes feat(fmt): support transient keyword by moving to Solar #9088
• fixes Forge fmt does not work with custom storage layouts 0.8.29 #10244

note that this does not support more than just number literals in "layout at" due to a bug in solang-parser / lalrpop (build script runs forever if we allow any expression in that position)

[grandizzy]

makes sense to keep us going until fully move to solar, @DaniPopes is the solang parser change something we could contribute upstream?

[DaniPopes]

it's not exactly the right implementation plus unlikely to be merged/released in any reasonable time

[zerosnacks]

note that this does not support more than just number literals in "layout at" due to a bug in solang-parser / lalrpop (build script runs forever if we allow any expression in that position)

Could we inform the user of this limitation when they try to format, given it is valid in the language?

Ref: https://docs.soliditylang.org/en/v0.8.29/contracts.html#custom-storage-layout

Error: Failed to parse Solidity code for src/Counter.sol. Leaving source unchanged.

Context:
- failed to parse file:
Error: ParserError
   ╭─[ :4:30 ]
   │
 4 │ contract Counter layout at 1 + 1 {
   │                              ┬  
   │                              ╰── unrecognised token '+', expected "{", "is", "layout"

[⠊] Compiling...
[⠆] Compiling 3 files with Solc 0.8.30
[⠔] Solc 0.8.30 finished in 251.13ms
Compiler run successful

[DaniPopes]

Can only do that in docs since error message is specific to the parser generator implementation

[zerosnacks]

Tested, lgtm 👍

In favor of shipping this patch to unblock, we can document the limitation in the release notes

[grandizzy]

👍

[wtdcode]

Why not use foundry_compilers::artifacts::Ast?

[DaniPopes]

The formatter was written 3 years ago with solang, and we've been slowly ripping it out in favor of solar: #9317

[wtdcode]

The formatter was written 3 years ago with solang, and we've been slowly ripping it out in favor of solar: #9317

Cool. Thanks for the instant response. solar is more promising indeed but it still lacks many side features, right? I mean why not just use existing solc ast bindings? This seems more feasible.

I haven't read a lot of code of these parts so feel free to correct me.

[DaniPopes]

solc AST is just bindings and not very ergonomic to use, solar is designed specifically for use as a library and is feature complete