feat: add overall discount to sales order and delivery note #47857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravibharathi656
requested review from
rohitwaghchaure and
ruthra-kumar
as code owners
… order and delivery note
ravibharathi656
force-pushed
the
add-overall-discount
branch
from
3f053b9 to
04f4a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable overall discount on Sales Order and Delivery Note by checking the "Is Cash or Non Trade Discount" checkbox.
Apply discount on grand total and carry forward to Sales Invoice.
Align behavior with existing Sales Invoice logic.
Sales Order:
Screen.Recording.2025-06-02.at.6.49.58.PM.1.mov
Delivery Note:
Screen.Recording.2025-06-02.at.6.52.38.PM.1.mov
resolves#47818
no-docs