Skip to content

Fix .NET Framework reference issue #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

CaptnCodr
Copy link
Member

@CaptnCodr CaptnCodr commented Aug 16, 2022

That fixes #212.
There was a little detail I have missed in the paket.template for each project.
Restrictions have been removed because the output libraries are the same but the target framework is different.

I have reproduced #212 and tested this solution locally and it works now as expected.

@sergey-tihon I would like ship it as fast as possible.

@CaptnCodr CaptnCodr requested a review from sergey-tihon August 16, 2022 07:19
@sergey-tihon
Copy link
Member

@CaptnCodr let's try it, you probably also want to bump version number

@CaptnCodr
Copy link
Member Author

@sergey-tihon Yes, I'll bump it to 5.0.3 and publish it now.

@CaptnCodr CaptnCodr merged commit d62b736 into fsprojects:master Aug 16, 2022
@CaptnCodr CaptnCodr deleted the bugfix/212-references branch August 16, 2022 08:34
@CaptnCodr
Copy link
Member Author

@sergey-tihon Should I maybe mark v5.0.2 as "Deprecated" > with Reason: "This package has critical bugs that make it unusable" at nuget.org?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error FS0074: The type referenced through 'NHamcrest.IMatcher`1' is defined in an assembly that is not referenced.
2 participants