Skip to content

Preserve backticked idents in Active Pattern idents #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2025
Merged

Preserve backticked idents in Active Pattern idents #3165

merged 3 commits into from
May 24, 2025

Conversation

dawedawe
Copy link
Member

fixes #3126

we can't directly reuse mkIdent as the backticks are inside the idText between the bars.

nojaf
nojaf approved these changes May 24, 2025
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks!

@dawedawe dawedawe merged commit bc7402c into fsprojects:main May 24, 2025
8 of 9 checks passed
@dawedawe dawedawe deleted the fix_3126 branch May 24, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Active patterns with defined with otherwise invalid name is incorrectly re-formatted
2 participants
@dawedawe @nojaf