Skip to content

[26.0] Fix workflow report time handling#19292

Merged
dannon merged 13 commits intogalaxyproject:release_26.0from
dannon:fix-invocation-time
Mar 17, 2026
Merged

[26.0] Fix workflow report time handling#19292
dannon merged 13 commits intogalaxyproject:release_26.0from
dannon:fix-invocation-time

Conversation

@dannon
Copy link
Copy Markdown
Member

@dannon dannon commented Dec 9, 2024

Fixes #19184, and consolidates handling (our 'Z'-appending hack) of galaxy timestamps. They are also now consistent with the 'pretty' format we use in the rest of the application. Adds some tests.

After:

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions Bot added this to the 25.0 milestone Dec 9, 2024
@dannon dannon force-pushed the fix-invocation-time branch from 6996a8d to 83f06ee Compare December 9, 2024 19:05
@dannon
Copy link
Copy Markdown
Member Author

dannon commented Dec 9, 2024

Looks like neither way I am trying to fake a timezone for jest have worked, still tinkering...

Copy link
Copy Markdown
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the unified handling! Much better now!

@dannon dannon force-pushed the fix-invocation-time branch from bdce81c to 5870f7b Compare December 10, 2024 12:48
@mvdbeek mvdbeek removed this from the 25.0 milestone May 12, 2025
@dannon dannon force-pushed the fix-invocation-time branch from 5870f7b to 74cde7d Compare March 11, 2026 20:18
@dannon dannon changed the base branch from release_24.2 to release_25.1 March 12, 2026 16:19
@dannon dannon force-pushed the fix-invocation-time branch from 74cde7d to e7a54c4 Compare March 12, 2026 16:20
@dannon dannon changed the base branch from release_25.1 to release_26.0 March 12, 2026 16:21
@dannon dannon changed the title [24.2] Fix workflow report time handling [26.0] Fix workflow report time handling Mar 12, 2026
@dannon
Copy link
Copy Markdown
Member Author

dannon commented Mar 12, 2026

Rebased this and retargeted this from 24.2 to 26.0.

@github-actions github-actions Bot added this to the 26.1 milestone Mar 12, 2026
@github-actions github-actions Bot changed the title [26.0] Fix workflow report time handling [25.1] Fix workflow report time handling Mar 12, 2026
@github-actions github-actions Bot changed the title [25.1] Fix workflow report time handling [26.0] Fix workflow report time handling Mar 12, 2026
@dannon dannon force-pushed the fix-invocation-time branch from e7a54c4 to f0c2278 Compare March 16, 2026 16:47
@dannon dannon merged commit dd290a7 into galaxyproject:release_26.0 Mar 17, 2026
56 of 58 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Mar 17, 2026
@itisAliRH itisAliRH deleted the fix-invocation-time branch March 25, 2026 15:57
@guerler guerler modified the milestones: 26.1, 26.0 Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants