Skip to content

Blur input path instead of requiring explicit enter in FormDirectory input#20047

Merged
ahmedhamidawan merged 3 commits intogalaxyproject:devfrom
dannon:form-directory-addpath
Jan 20, 2026
Merged

Blur input path instead of requiring explicit enter in FormDirectory input#20047
ahmedhamidawan merged 3 commits intogalaxyproject:devfrom
dannon:form-directory-addpath

Conversation

@dannon
Copy link
Copy Markdown
Member

@dannon dannon commented Apr 18, 2025

This should address users not knowing they need to explicitly hit enter to add the path; instead, we check when focus is lost and if it's valid we apply pending changes.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon changed the title Add form directory input on blur as well as enter; ensure valid though. FormDirectory -- input path on blur instead of requiring explicit enter Apr 18, 2025
@jmchilton jmchilton mentioned this pull request Apr 18, 2025
1 task
Copy link
Copy Markdown
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, I think we can move it out of draft and merge?

@dannon
Copy link
Copy Markdown
Member Author

dannon commented May 12, 2025

Ahmed and I talked out band, but to update here -- I think I need to adjust handleblur but I want to add some extra tests that I haven't been able to get to yet. this will be a bugfix, and we can retarget 24.2 if we want, so I'll get to this during the freeze.

@dannon dannon force-pushed the form-directory-addpath branch from c6d8287 to 93aa658 Compare January 14, 2026 16:13
@dannon dannon marked this pull request as ready for review January 14, 2026 17:00
@github-actions github-actions Bot added this to the 26.0 milestone Jan 14, 2026
Copy link
Copy Markdown
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dannon !

@ahmedhamidawan ahmedhamidawan merged commit 6b0f968 into galaxyproject:dev Jan 20, 2026
30 of 33 checks passed
@itisAliRH itisAliRH deleted the form-directory-addpath branch January 20, 2026 11:46
@guerler guerler changed the title FormDirectory -- input path on blur instead of requiring explicit enter Blur input path instead of requiring explicit enter in FormDirectory input Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants