Blur input path instead of requiring explicit enter in FormDirectory input#20047
Merged
ahmedhamidawan merged 3 commits intogalaxyproject:devfrom Jan 20, 2026
Merged
Conversation
1 task
ahmedhamidawan
approved these changes
May 7, 2025
Member
ahmedhamidawan
left a comment
There was a problem hiding this comment.
I like this change, I think we can move it out of draft and merge?
Member
Author
|
Ahmed and I talked out band, but to update here -- I think I need to adjust handleblur but I want to add some extra tests that I haven't been able to get to yet. this will be a bugfix, and we can retarget 24.2 if we want, so I'll get to this during the freeze. |
c6d8287 to
93aa658
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address users not knowing they need to explicitly hit enter to add the path; instead, we check when focus is lost and if it's valid we apply pending changes.
How to test the changes?
(Select all options that apply)
License