Skip to content

Remove Trackster#20974

Merged
guerler merged 16 commits intogalaxyproject:devfrom
guerler:remove_trackster
Oct 13, 2025
Merged

Remove Trackster#20974
guerler merged 16 commits intogalaxyproject:devfrom
guerler:remove_trackster

Conversation

@guerler
Copy link
Copy Markdown
Contributor

@guerler guerler commented Sep 29, 2025

Now that we have IGV, this PR completely removes Trackster and its traces from the code base. It removes special handling for Trackster across tool execution, tool box filtering, visualization framework features, controller endpoints, client code, and other conditional logic. With the removal of Trackster, the era of Mako-based visualizations served from controller endpoints ends.

xref: #17158 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 26.0 milestone Sep 29, 2025
@guerler guerler added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Sep 29, 2025
@itisAliRH
Copy link
Copy Markdown
Member

We should rebase #18451 since it contains some parts of this PR, but it is outdated.

@guerler guerler marked this pull request as ready for review October 8, 2025 04:25
@guerler guerler requested a review from davelopez October 8, 2025 04:26
@guerler guerler mentioned this pull request Oct 10, 2025
4 tasks
Copy link
Copy Markdown
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sam! It looks good to me 👍

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Oct 13, 2025

So cool that we'll be able to remove all that code, however I haven't figured out yet how to add a reference genome (i.e a fasta file form history) to IGV. This seems like something we should have before we can remove trackster ? Apologies if this is already possible and I just didn't find it ...

@guerler
Copy link
Copy Markdown
Contributor Author

guerler commented Oct 13, 2025

@mvdbeek I haven’t implemented that yet. Users can already select FASTA files from the history to add them as tracks. Allowing FASTA selection from the history as a reference genome would be straightforward, but I preferred to first revise the custom builds interface to support not only simple FASTA files but also SAM index and 2bit formats, which is why it’s not added yet. However, I will definitely add it before the next release, and I don’t think it should hold this PR back.

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Oct 13, 2025

There's still a lot of work left I think in making IGV work as well as trackster, are you sure one cycle is enough ? Adding fasta as a track isn't useful, if there's no overlap between the actual reference genome you can't even see the track data.
If it's helpful I can open an issue with all the additional things i've found.

@guerler
Copy link
Copy Markdown
Contributor Author

guerler commented Oct 13, 2025

@mvdbeek yes, opening a detailed issue outlining all required features would be excellent, thank you.

@guerler guerler merged commit 4608a6a into galaxyproject:dev Oct 13, 2025
66 of 68 checks passed
@mvdbeek mvdbeek mentioned this pull request Oct 14, 2025
8 tasks
@guerler guerler deleted the remove_trackster branch October 27, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants