Conversation
|
We should rebase #18451 since it contains some parts of this PR, but it is outdated. |
42bd893 to
ed65aa8
Compare
7e687f5 to
31cd726
Compare
…visited separately
davelopez
left a comment
There was a problem hiding this comment.
Thank you, Sam! It looks good to me 👍
|
So cool that we'll be able to remove all that code, however I haven't figured out yet how to add a reference genome (i.e a fasta file form history) to IGV. This seems like something we should have before we can remove trackster ? Apologies if this is already possible and I just didn't find it ... |
|
@mvdbeek I haven’t implemented that yet. Users can already select FASTA files from the history to add them as tracks. Allowing FASTA selection from the history as a reference genome would be straightforward, but I preferred to first revise the custom builds interface to support not only simple FASTA files but also SAM index and 2bit formats, which is why it’s not added yet. However, I will definitely add it before the next release, and I don’t think it should hold this PR back. |
|
There's still a lot of work left I think in making IGV work as well as trackster, are you sure one cycle is enough ? Adding fasta as a track isn't useful, if there's no overlap between the actual reference genome you can't even see the track data. |
|
@mvdbeek yes, opening a detailed issue outlining all required features would be excellent, thank you. |
Now that we have IGV, this PR completely removes Trackster and its traces from the code base. It removes special handling for Trackster across tool execution, tool box filtering, visualization framework features, controller endpoints, client code, and other conditional logic. With the removal of Trackster, the era of Mako-based visualizations served from controller endpoints ends.
xref: #17158 (comment)
How to test the changes?
(Select all options that apply)
License