Move database revision tags to separate file#20998
Conversation
|
|
|
I see your point. The goal is not to suggest configurability, but to separate static release data from code. Right now release managers must edit a code file with logic just to add a new tag. Moving this into a data-only file avoids that. If YAML feels misleading, we could use a dbrevisions.json file instead. A minimal dbrevisions.py with just a dict would also work, but YAML or JSON seem clearer. |
|
Every time we load stuff from disk in the module namespace we slow down the startup process. I'm with @jdavcs on this one. You can also validate that the head revision is listed in the migration tests for instance so bumping this would be up to whoever adds a migration. |
b8ef8cb to
22e47d7
Compare
|
Thanks for the review and suggestions. Does this look ok now @jdavcs? |
22e47d7 to
7473d8a
Compare
This change moves
REVISION_TAGSinto a constant-onlydbrevisions.pyfile, simplifying maintenance.How to test the changes?
(Select all options that apply)
License