Skip to content

Simplify transiently failing test (#21224) see if this stabilizes it at all #21239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmchilton merged 1 commit into from
Nov 5, 2025
Merged

Simplify transiently failing test (#21224) see if this stabilizes it at all #21239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/galaxy_test/selenium/test_history_sharing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,14 @@ def test_sharing_private_history_default_permission(self):

# Verify the permission change required dialog appears
self.screenshot("history_private_sharing_permissions_dialog")
self.components.histories.sharing.permissions_change_required.wait_for_visible()

# The next line seems flakey for reasons I don't understand. The data
# description is attached the model and I do see the modal visually but
# maybe the modal is not visible because of the modal content or something?
# At any rate - the following wait would be totally sufficient to ensure
# the modal is rendered and to continue with the test - so I'm going to
# just comment out this line and see if it resolves #21224.
# self.components.histories.sharing.permissions_change_required.wait_for_visible()

# Verify the default selected option is 'make_accessible_to_shared'
element = self.components.histories.sharing.permissions_change_required_how.wait_for_visible()
Expand Down
Loading