Skip to content

Add "show in multiview" to mutiple history selection#21260

Merged
itisAliRH merged 7 commits intogalaxyproject:devfrom
davelopez:history_list_bulk_multiview
Nov 19, 2025
Merged

Add "show in multiview" to mutiple history selection#21260
itisAliRH merged 7 commits intogalaxyproject:devfrom
davelopez:history_list_bulk_multiview

Conversation

@davelopez
Copy link
Copy Markdown
Contributor

Closes #21177

When 2 or more histories are selected, the Open in Multiview button is enabled to show them in the Multi-history view.

BulkMultiview.mp4

Currently, the maximum number of histories that can be opened at once is (arbitrarily) limited to 10, and if the number of selected histories is greater, you will see a confirmation message telling you that only 10 will be opened. This is to avoid the easy combination of "select all" with a huge number of histories in the account, which will likely hurt performance. But the limit of 10 can be changed to any other appropriate value if desired.

Screenshot from 2025-11-07 17-17-39

TODO

  • Add some selenium tests

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Prevents users from opening more than 10 histories in multiview at once by prompting for confirmation and trimming the selection if exceeded. Improves usability by clarifying limits and preventing accidental overload.
Introduces a test to verify that attempting to open more than the allowed maximum number of histories in multiview triggers a confirmation dialog, and ensures only the permitted number are opened.
It shows the correct number of histories selected in case we exceeded the limit
@davelopez davelopez marked this pull request as ready for review November 10, 2025 16:35
@github-actions github-actions Bot added this to the 26.0 milestone Nov 10, 2025
@davelopez
Copy link
Copy Markdown
Contributor Author

Test failures are unrelated and likely transient.

Copy link
Copy Markdown
Member

@itisAliRH itisAliRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @davelopez!

@itisAliRH itisAliRH merged commit 28e0f2b into galaxyproject:dev Nov 19, 2025
38 of 41 checks passed
@davelopez davelopez deleted the history_list_bulk_multiview branch November 20, 2025 09:46
@martenson
Copy link
Copy Markdown
Member

thanks @davelopez ! marvelous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add "show in multiview" to mutiple history selection

3 participants