Conversation
|
I have tested the |
nuwang
left a comment
There was a problem hiding this comment.
Thanks for this, looks great to me! Let me know when it's ready for testing.
Use a better name for the pull request token. Co-authored-by: Nuwan Goonasekera <2070605+nuwang@users.noreply.github.com>
I think this is ready for testing. At least I think I've done all the testing that I can as is. Do you have suggestions for testing beyond releasing this into the wild and see how it does? |
I should have said - can it be taken out of review? I agree with what you said about testing |
|
I was going to take it out of Draft once we had the token set up. Maybe @afgane can do that? |
|
I've added the token @ksuderman. It only has PR read-write permissions on the galaxy-helm repo. Let me know if it needs more perms than that. |
|
That should be enough. I guess we will find out when it attempts to create a PR. |
| with: | ||
| repository: galaxyproject/galaxy-helm | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| persist-credentials: true |
There was a problem hiding this comment.
@ksuderman I'm reviewing our use of persist-credentials and I think it should be set to false here, as you are using a different token when creating the pull request?
Also the token line can be removed.
This PR adds two new jobs to the
build_container_image.yamlworkflow.Outstanding issues
GITHUB_TOKENused to create a PR in the Galaxy Helm repository has permission.sedto generate the PR is fragileLicense