Update error message handling for OIDC

[uwwint]

Change OIDC error handling. In case error_description is provided to the callback render that message to the user instead of the default text in Galaxy. Also update the UI to kick the user back to the login screen with the usual error handling

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. configure an OIDC provider
  2. login with a user into the OIDC provider which triggers an error
  3. Observe the error is shown on the login screen. if the callback parameter error_description is not provided, the standard galaxy message is shown.

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[uwwint]

Hi @nuwang @bgruening,

can you help with getting this UX improvement in?

Kind Regards,
Uwe

[nuwang]

Server side changes look ok to me, thanks @uwwint. Have left some minor comments. @ahmedhamidawan Would you be able to review front-end changes please?

[ahmedhamidawan]

Server side changes look ok to me, thanks @uwwint. Have left some minor comments. @ahmedhamidawan Would you be able to review front-end changes please?

Thank you @nuwang and @uwwint , I can run this locally and test out several use cases. It might take me towards the end of the week because of the Galaxy Team Meeting right now.

[ahmedhamidawan]

Client changes look good to me!

@uwwint please run the following commands to lint the backend before you commit your changes:

% make format && tox -e lint && tox -e mypy

And the following for client side changes:

% cd client && yarn run prettier --check
% cd client && yarn run eslint

[uwwint]

@ahmedhamidawan will do next time - I understand that this has already been run on this branch, correct?

I created fast pre-commit hooks in this branch of my own: https://github.com/uwwint/galaxy/tree/feature/pre-commit

not sure this is something the project would like. But if they do, I am happy to PR it.

[ahmedhamidawan]

@uwwint Yes, these changes are linted now
I shared a link to that pre-commit commit in the backend channel, if anyone's interested, thanks!

[nuwang]

Existing pre-commit hooks are here: https://github.com/galaxyproject/galaxy/blob/dev/.pre-commit-config.yaml.sample