Skip to content

Don't set OAUTHLIB_INSECURE_TRANSPORT setting in user_data#21451

Merged
mvdbeek merged 2 commits intogalaxyproject:devfrom
nuwang:remove_oauthlib_insecure_transport
Dec 15, 2025
Merged

Don't set OAUTHLIB_INSECURE_TRANSPORT setting in user_data#21451
mvdbeek merged 2 commits intogalaxyproject:devfrom
nuwang:remove_oauthlib_insecure_transport

Conversation

@nuwang
Copy link
Copy Markdown
Member

@nuwang nuwang commented Dec 13, 2025

This PR:

  1. Remove setting OAUTHLIB_INSECURE_TRANSPORT in code. Admins wishing to test insecure localhost redirect endpoints will need to set the environment variable OAUTHLIB_INSECURE_TRANSPORT manually.
  2. Removes unnecessary test code
  3. Fixes an error when parsing session token

Fixes: #21234 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions Bot added area/testing area/auth Authentication and authorization labels Dec 13, 2025
@github-actions github-actions Bot added this to the 26.0 milestone Dec 13, 2025
@nuwang nuwang requested a review from mvdbeek December 14, 2025 05:24
@mvdbeek mvdbeek merged commit 429228f into galaxyproject:dev Dec 15, 2025
77 of 84 checks passed
@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Dec 15, 2025

Thank you @nuwang!

@nuwang nuwang deleted the remove_oauthlib_insecure_transport branch December 15, 2025 11:30
@galaxyproject galaxyproject deleted a comment from github-actions Bot Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication and authorization area/testing kind/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants