Implement subworkflow invocation export#21512
Conversation
github-actions
Bot
added
area/testing
area/database
| f"Expected at least {len(datasets)} files in RO-Crate, " | ||
| f"but found {len(files)}. This suggests subworkflow datasets may not be exported." | ||
| ) | ||
|
|
There was a problem hiding this comment.
Another amazing bug fix - I cannot believe this was never implemented - someone should yell at @jmchilton. In terms of the test I'm less concerned about what is in the RO Crate than whether we can do tool reruns on the subworkflow steps but maybe that is a big ask? I guess... another richer test would be can you re-export the invocation and is the subworkflow stuff still there on re-export. So this same test but on a re-import and re-export. That maybe is easier and tells us we've reassembled the models and metadata correctly internally and doesn't require navigating down into the subworkflow to find a rerun to do.
There was a problem hiding this comment.
That was a really good suggestion, the round-trip revealed that we didn't wire up the subworkflow invocation!
There was a problem hiding this comment.
Lovely - thank you so much for doing that! I'm glad the test improvement suggestion proved immediately useful.
mvdbeek
force-pushed
the
implement-subworkflow-invocation-export
branch
2 times, most recently
from
6a71e68 to
699f31f
Compare
And verify export-import-export roundtrip
mvdbeek
force-pushed
the
implement-subworkflow-invocation-export
branch
from
699f31f to
cce7bcc
Compare
|
Remaining test errors should be unrelated |
guerler
added
the
release-testing-26.0
3 participants
Closes #19217
How to test the changes?
(Select all options that apply)
License