Fix toolshed tests on Python 3.14#21617
Merged
mvdbeek merged 4 commits intogalaxyproject:devfrom Jan 20, 2026
Merged
Conversation
nsoranzo
reviewed
Jan 19, 2026
jmchilton
approved these changes
Jan 19, 2026
Mercurial 7.2rc0 is the first release with Python 3.14 support. Running 7.1.2 on Python 3.14 causes significant performance issues that lead to test timeouts. Use version markers to specify 7.2rc0 for Python 3.14+ while keeping 7.1.2 for earlier Python versions.
The cmdutil.findpossible function was removed in Mercurial 7.2. Instead of introspecting the command table to get diff defaults, use mdiff.diffopts.defaults directly which is more stable.
Previously, reset_all_metadata_on_repository_in_tool_shed() cloned the repository separately for each changeset revision over HTTP. With 6 changesets at ~6-7 seconds per clone, this took ~40 seconds total, exceeding Playwright's 30-second timeout. Now clone the repository once and use hg update to switch between revisions. This reduces 6 network round-trips to 1, making the operation complete well within the timeout.
mvdbeek
force-pushed
the
fix-toolshed-tests
branch
from
0b69c3a to
8e04871
Compare
nsoranzo
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key fix is the update to 7.2, but the last commit is a nice optimization that claude thought at first was the issue.
How to test the changes?
(Select all options that apply)
License