Skip to content

Fix ace import in cell-based markdown editor#21622

Merged
jmchilton merged 2 commits intogalaxyproject:devfrom
guerler:fix_ace_import
Jan 27, 2026
Merged

Fix ace import in cell-based markdown editor#21622
jmchilton merged 2 commits intogalaxyproject:devfrom
guerler:fix_ace_import

Conversation

@guerler
Copy link
Copy Markdown
Contributor

@guerler guerler commented Jan 20, 2026

Switch to static imports to allow Vite to resolve them.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 26.0 milestone Jan 20, 2026
@guerler guerler requested a review from dannon January 20, 2026 10:15
@guerler guerler marked this pull request as ready for review January 20, 2026 10:16
@jmchilton
Copy link
Copy Markdown
Member

Client lint errors look relevant:

/home/runner/work/galaxy/galaxy/client/src/components/Markdown/Editor/CellCode.vue
Error: 6:1 error Run autofix to sort these imports! simple-import-sort/imports

@jmchilton jmchilton merged commit 7b9d336 into galaxyproject:dev Jan 27, 2026
32 checks passed
@itisAliRH itisAliRH deleted the fix_ace_import branch January 28, 2026 18:49
@guerler guerler added the release-testing-26.0 PRs marked for testing for the 26.0 release and issues stemming from release testing label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/UI-UX kind/bug release-testing-26.0 PRs marked for testing for the 26.0 release and issues stemming from release testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants