Skip to content

[26.0] Deserialize json string for export_metadata from old records #21772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davelopez merged 2 commits into from
Feb 6, 2026
Merged

[26.0] Deserialize json string for export_metadata from old records #21772

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97c42b8
Deserialize json string for older export_metadata from old records
mvdbeek Feb 6, 2026
70e8913
Explicitly state the possible types if export.export_metadata
mvdbeek Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/galaxy/managers/export_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import json
from datetime import (
datetime,
timedelta,
Expand Down Expand Up @@ -119,7 +120,13 @@ def get_user_exports(
for export in all_exports:
if export.export_metadata:
# Access dict directly - JSONType handles deserialization
stored_user_id = export.export_metadata.get("request_data", {}).get("user_id")
# however old records might be JSON strings.
export_metadata = (
json.loads(export.export_metadata)
if isinstance(export.export_metadata, str) # type: ignore[unreachable]
else export.export_metadata
)
Comment thread
mvdbeek marked this conversation as resolved.
Outdated
stored_user_id = export_metadata.get("request_data", {}).get("user_id")
if stored_user_id == encoded_user_id:
user_exports.append(export)
if limit and len(user_exports) >= limit:
Expand Down
Loading