Skip to content

[26.0] Use 1-based step index in invocation metric UI#21799

Merged
mvdbeek merged 1 commit intogalaxyproject:release_26.0from
mvdbeek:fix_invocation_step_index_off_0_based
Feb 10, 2026
Merged

[26.0] Use 1-based step index in invocation metric UI#21799
mvdbeek merged 1 commit intogalaxyproject:release_26.0from
mvdbeek:fix_invocation_step_index_off_0_based

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Feb 9, 2026

Fixes #21784

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Copy Markdown
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, this fixes the indexing, thank you!

Copy link
Copy Markdown
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have library functionality somewhere that is used between different components to render displayed index from the index in the API. I prefer "use this abstraction" to "add one anywhere we display it". Maybe too much to ask for a bug fix though.

@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Feb 10, 2026

Do we use the nested step index anywhere else ? WES, but it doesn't have a frontend ?

@mvdbeek mvdbeek closed this Feb 10, 2026
@mvdbeek mvdbeek reopened this Feb 10, 2026
@mvdbeek mvdbeek merged commit 2905e9a into galaxyproject:release_26.0 Feb 10, 2026
57 of 88 checks passed
@nsoranzo nsoranzo deleted the fix_invocation_step_index_off_0_based branch February 10, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants