Skip to content

[26.0] Parse input collections as well in markdown editor#21913

Merged
ahmedhamidawan merged 2 commits intogalaxyproject:release_26.0from
ahmedhamidawan:parse_input_collections_in_reports
Feb 24, 2026
Merged

[26.0] Parse input collections as well in markdown editor#21913
ahmedhamidawan merged 2 commits intogalaxyproject:release_26.0from
ahmedhamidawan:parse_input_collections_in_reports

Conversation

@ahmedhamidawan
Copy link
Copy Markdown
Member

@ahmedhamidawan ahmedhamidawan commented Feb 24, 2026

For markdown objects that fetch invocations like:

history_dataset_as_image(invocation_id=b7c1d0811979026c, input="ROI image for staining analysis")

We were not parsing workflow inputs that are collections. So, these inputs were being treated as history_dataset_ids. Now, we check the input.src and if it is an hdca we return a history_dataset_collection_id instead of a history_dataset_id.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

For markdown objects that fetch invocations like:
```
history_dataset_as_image(invocation_id=b7c1d0811979026c, input="ROI image for staining analysis")
```

We were not parsing workflow inputs that are collections. So, these inputs were being treated as `history_dataset_id`s. Now, we check the input.src and if it is an `hdca` we return a `history_dataset_collection_id` instead of a `history_dataset_id`.
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review February 24, 2026 14:57
@ahmedhamidawan ahmedhamidawan merged commit 3843fab into galaxyproject:release_26.0 Feb 24, 2026
31 of 32 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Feb 24, 2026
@ahmedhamidawan ahmedhamidawan deleted the parse_input_collections_in_reports branch February 24, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants