Skip to content

[26.0] Fix collection step Job markdown elements not rendering#21917

Merged
jmchilton merged 2 commits intogalaxyproject:release_26.0from
ahmedhamidawan:fix_job_parameters_not_shown_for_collections
Feb 24, 2026
Merged

[26.0] Fix collection step Job markdown elements not rendering#21917
jmchilton merged 2 commits intogalaxyproject:release_26.0from
ahmedhamidawan:fix_job_parameters_not_shown_for_collections

Conversation

@ahmedhamidawan
Copy link
Copy Markdown
Member

We weren't rendering markdown elements that required a job_id but instead of a job id in the arguments, had an implicit_collection_jobs_id (it's a collection step).

Now, the hasValidObject method in client/src/components/Markdown/Utilities/requirements.ts checks for this.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

ahmedhamidawan and others added 2 commits February 24, 2026 13:24
We weren't rendering markdown elements that required a `job_id` but instead of a job id in the arguments, had an `implicit_collection_jobs_id` (it's a collection step).

Now, the `hasValidObject` method in `client/src/components/Markdown/Utilities/requirements.ts` checks for this.
@ahmedhamidawan ahmedhamidawan added this to the 26.0 milestone Feb 24, 2026
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review February 24, 2026 19:30
@jmchilton jmchilton merged commit e25fa26 into galaxyproject:release_26.0 Feb 24, 2026
31 of 32 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Feb 24, 2026
@ahmedhamidawan ahmedhamidawan deleted the fix_job_parameters_not_shown_for_collections branch February 24, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants