[26.0] Fix collection step Job markdown elements not rendering#21917
Merged
jmchilton merged 2 commits intogalaxyproject:release_26.0from Feb 24, 2026
Merged
Conversation
We weren't rendering markdown elements that required a `job_id` but instead of a job id in the arguments, had an `implicit_collection_jobs_id` (it's a collection step). Now, the `hasValidObject` method in `client/src/components/Markdown/Utilities/requirements.ts` checks for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't rendering markdown elements that required a
job_idbut instead of a job id in the arguments, had animplicit_collection_jobs_id(it's a collection step).Now, the
hasValidObjectmethod inclient/src/components/Markdown/Utilities/requirements.tschecks for this.How to test the changes?
(Select all options that apply)
License