[26.0] AttributeError when history is None during tool execution#22031
Merged
jmchilton merged 1 commit intogalaxyproject:release_26.0from Mar 12, 2026
Merged
Conversation
When executing tools via the API without a history_id and no active session history, the history variable is None, causing a crash at history.add_pending_items(). This raises a clear error early in the service layer and adds a defensive guard in execute.py. Fixes galaxyproject#22018
Member
I'm assuming this can't be related - but I don't recall ever seeing it fail before. I'll rerun that test. |
Member
Author
httpstat.us down / unreachable etc. I think you fixes this on the dev branch ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing tools via the API without a history_id and no active session history, the history variable is None, causing a crash at history.add_pending_items(). This raises a clear error early in the service layer and adds a defensive guard in execute.py.
Fixes #22018
How to test the changes?
(Select all options that apply)
License