[26.0] Use mock test server when tests don't target external galaxy server#22103
Merged
jmchilton merged 3 commits intogalaxyproject:release_26.0from Mar 13, 2026
Merged
Conversation
…tests Replace external service dependencies in test_tools_upload.py with a local mock HTTP server. The MockHttpServer fixture provides a get_url() factory that registers routes on a local stdlib HTTP server for local Galaxy testing, and falls back to the real external URLs (with skip-if-down) when targeting a remote Galaxy server via GALAXY_TEST_EXTERNAL.
Remove skip_if_github_down decorators from 20 tests across 9 files by serving test data from the local mock HTTP server. Enhances the mock server with file_path support, HEAD requests, and HTTP range requests (206 Partial Content). For unit tests that run data_fetch.main() directly, writes a file_sources.json with 127.0.0.0/24 in the fetch_url_allowlist so the local server passes URI validation.
mvdbeek
force-pushed
the
use-mock-test-server
branch
from
e5424b1 to
fddbd36
Compare
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this gives us a lot of flexibility, we can target local and remote Galaxy instances with the same test syntax,
and CI tests don't get rate limited by github or make requests against usegalaxy.org or fail on httpstat.us.
How to test the changes?
(Select all options that apply)
License