[26.0] Fix WSGI middlewares returning strings#22108
Merged
mvdbeek merged 2 commits intogalaxyproject:release_26.0from Mar 14, 2026
Merged
[26.0] Fix WSGI middlewares returning strings#22108mvdbeek merged 2 commits intogalaxyproject:release_26.0from
mvdbeek merged 2 commits intogalaxyproject:release_26.0from
Conversation
The error inner function was used as a WSGI sub-application but returned a bare string. WSGI requires response bodies to be iterables of byte strings. With a2wsgi converting to ASGI, h11 rejects the str, causing a TypeError in starlette's BaseHTTPMiddleware.
jmchilton
approved these changes
Mar 14, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should remove the unused ones in dev.
How to test the changes?
(Select all options that apply)
License