Skip to content

[25.1] Use /api/tool_data endpoints in DataTables.vue & DataManagerTable.vue#22229

Merged
mvdbeek merged 1 commit intogalaxyproject:release_25.1from
mvdbeek:fix-data-table-reload-admin-interface
Mar 24, 2026
Merged

[25.1] Use /api/tool_data endpoints in DataTables.vue & DataManagerTable.vue#22229
mvdbeek merged 1 commit intogalaxyproject:release_25.1from
mvdbeek:fix-data-table-reload-admin-interface

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Mar 23, 2026

Switch from legacy controller axios calls to the typed GalaxyApi() fetcher for both loading and reloading tool data tables. Remove the now-unused tool_data_table_info, tool_data_table_info_1, and reload_tool_data_tables methods from the data_manager controller.

Fixes #22227, because the old controller method reload_tool_data_table did not in fact reload the tool data table

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Switch from legacy controller axios calls to the typed GalaxyApi() fetcher
for both loading and reloading tool data tables. Remove the now-unused
tool_data_table_info, tool_data_table_info_1, and reload_tool_data_tables
methods from the data_manager controller.

Fixes galaxyproject#22227
@github-actions github-actions Bot changed the title [Use /api/tool_data endpoints in DataTables.vue & DataManagerTable.vue [25.1] [Use /api/tool_data endpoints in DataTables.vue & DataManagerTable.vue Mar 23, 2026
@github-actions github-actions Bot added this to the 26.1 milestone Mar 23, 2026
@mvdbeek mvdbeek changed the title [25.1] [Use /api/tool_data endpoints in DataTables.vue & DataManagerTable.vue [25.1] Use /api/tool_data endpoints in DataTables.vue & DataManagerTable.vue Mar 23, 2026
@ahmedhamidawan ahmedhamidawan modified the milestones: 26.1, 26.0 Mar 23, 2026
@mvdbeek mvdbeek requested a review from martenson March 23, 2026 17:18
@mvdbeek mvdbeek merged commit c896259 into galaxyproject:release_25.1 Mar 24, 2026
54 of 61 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Mar 24, 2026
@martenson
Copy link
Copy Markdown
Member

thanks @mvdbeek

@nsoranzo nsoranzo deleted the fix-data-table-reload-admin-interface branch March 24, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants