[26.0] Fix batch history purge not updating user's update_time#22238
Merged
nsoranzo merged 1 commit intogalaxyproject:release_26.0from Mar 24, 2026
Merged
Conversation
The batch purge_history_datasets celery task uses raw SQL for bulk operations, bypassing SQLAlchemy's onupdate=now trigger on User.update_time. This caused archiving with purge to leave the user's update_time stale. Also forwards preserve_owner_update_time through to the batch task so admin-initiated purges of other users' histories still preserve the owner's update_time.
mvdbeek
added
kind/bug
area/testing
area/database
4 tasks
nsoranzo
approved these changes
Mar 24, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch
purge_history_datasetscelery task uses raw SQL for bulk operations, bypassing SQLAlchemy'sonupdate=nowtrigger onUser.update_time. This caused archiving with purge to leave the user'supdate_timestale, see #22180 (comment) .Also forwards
preserve_owner_update_timethrough to the batch task so admin-initiated purges of other users' histories still preserve the owner'supdate_time.How to test the changes?
(Select all options that apply)
License