Skip to content

[26.0] Delete dummy error controller, fix type error on invalid requests#22245

Merged
jmchilton merged 2 commits intogalaxyproject:release_26.0from
mvdbeek:sentry_api_bug_issues
Mar 26, 2026
Merged

[26.0] Delete dummy error controller, fix type error on invalid requests#22245
jmchilton merged 2 commits intogalaxyproject:release_26.0from
mvdbeek:sentry_api_bug_issues

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Mar 24, 2026

2 for 1, fixes #22244 and #22243

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek added 2 commits March 24, 2026 14:52
…ameter

If a request includes a query parameter named `method`, it ends up in
kwargs, and the call to handle_controller_exception unpacks it alongside
the positional `method` argument, causing a TypeError. Pass kwargs as a
plain dict instead of unpacking to avoid any possible collision.

Fixes galaxyproject#22243
@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Mar 25, 2026

Test error unrelated

@mvdbeek mvdbeek requested a review from a team March 25, 2026 09:21
@jmchilton jmchilton merged commit c4374c0 into galaxyproject:release_26.0 Mar 26, 2026
51 of 57 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Mar 26, 2026
@ahmedhamidawan ahmedhamidawan modified the milestones: 26.1, 26.0 Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants