[26.0] Fix HDCA lost in tool form on rerun#22258
Merged
mvdbeek merged 2 commits intogalaxyproject:release_26.0from Mar 26, 2026
Merged
[26.0] Fix HDCA lost in tool form on rerun#22258mvdbeek merged 2 commits intogalaxyproject:release_26.0from
mvdbeek merged 2 commits intogalaxyproject:release_26.0from
Conversation
natefoo
approved these changes
Mar 25, 2026
jmchilton
approved these changes
Mar 26, 2026
Member
jmchilton
left a comment
jmchilton
left a comment
There was a problem hiding this comment.
You know I hate that file but this fix is actually really legible - thank you so much! Thanks for creating abstractions for testing also - I appreciate that.
Tests for hidden/deleted HDA display in the rerun form now use real model.HistoryDatasetAssociation instances via _new_hda(), since these go through the isinstance check in the job_input_values loop. The MockHistoryDatasetAssociation (which stubs find_conversion_destination) is retained only for conversion tests that go through the dataset matcher path and never reach the isinstance branch.
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
Member
Author
|
Too many flaky failures, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nekrut noticed missing input on rerun:
This happens when the HDCA is hidden or you're not currently in the history because the loop would group the HDCA (which have hids ...) as HDA and put it in the wrong options.
How to test the changes?
(Select all options that apply)
License