[26.0] Fix OMERO temp directory handling#22262
Merged
mvdbeek merged 2 commits intogalaxyproject:release_26.0from Mar 31, 2026
Merged
[26.0] Fix OMERO temp directory handling#22262mvdbeek merged 2 commits intogalaxyproject:release_26.0from
mvdbeek merged 2 commits intogalaxyproject:release_26.0from
Conversation
Avoids import-time side effects that can interfere with temp directory handling and startup behavior. Configures a stable temp location before the dependency is loaded so runtime behavior stays predictable across deployments. Moves dependency checks to connection time, which lets initialization remain lightweight while still failing clearly when support is unavailable.
Detects the case where authentication appears to succeed but no active client session is available. Raises a clearer failure instead of calling keepalive on a missing client, which makes connection problems easier to diagnose and prevents a less helpful runtime error.
Contributor
|
Is the |
Contributor
Author
|
This is documented in the general Galaxy config file; it is not part of the template config but rather a global config for all file sources: galaxy/lib/galaxy/config/sample/galaxy.yml.sample Line 3129 in 173df77 |
Member
|
Could you report this upstream ? |
mvdbeek
approved these changes
Mar 29, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22203
Galaxy loads all file sources on startup, so the only workaround Copilot and I could find is deferring the OMERO import until it is really used to avoid the import side effect of setting the temp directory to the default directory in the user's home dir before we can set the
OMERO_TMPDIRto a sensible value.This will now use the directory in
file_source_temp_diror try a sensible fallback withtempfile.gettempdir().Thanks again for noticing this @bernt-matthias! Can you give it a try?
How to test the changes?
License